Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: form missing motion validate #38962

Merged
merged 2 commits into from Nov 24, 2022
Merged

fix: form missing motion validate #38962

merged 2 commits into from Nov 24, 2022

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 24, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #38947

💡 Background and solution

😆 一个多出的 prop 引发的惨案,我都开始怀疑自己的 CSS 知识了,233~

https://github.com/ant-design/ant-design/pull/36597/files#diff-882ca2243b17a2c4a7dd71f424d5b9cb20793979210931c77a259ce8bace8248R77

📝 Changelog

Language Changelog
🇺🇸 English Fix Form validation motion flick issue.
🇨🇳 Chinese 修复 Form 校验信息动效卡顿的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2022

@github-actions
Copy link
Contributor

Size Change: +334 B (0%)

Total Size: 900 kB

Filename Size Change
./dist/antd-with-locales.min.js 479 kB +243 B (0%)
./dist/antd.min.js 421 kB +91 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (c924f0e) compared to base (403d345).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38962   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          544       545    +1     
  Lines         9350      9354    +4     
  Branches      2649      2649           
=========================================
+ Hits          9350      9354    +4     
Impacted Files Coverage Δ
components/form/ErrorList.tsx 100.00% <100.00%> (ø)
components/form/style/explain.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit 5037708 into master Nov 24, 2022
@zombieJ zombieJ deleted the form-validate-motion branch November 24, 2022 13:43
This was referenced Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants