Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix support options #38968

Merged
merged 2 commits into from Nov 25, 2022
Merged

Conversation

heiyu4585
Copy link
Contributor

@heiyu4585 heiyu4585 commented Nov 24, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 1. Fix Metions 'options' props not working. 2. menu Repair using react18 antd_ 4.24.0, the menu flashes and the default style is lost. 3. Fix the menu flashes when the Sider of Layout is folded
🇨🇳 Chinese 1 . 修复 Mentions options 不生效问题。 2. menu 修复使用 react18 antd_4.24.0, 菜单闪烁,丢失默认样式 3. 修复Layout的Sider折叠时Menu闪烁

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2022

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (38917cf) compared to base (5037708).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38968   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          545       545           
  Lines         9354      9357    +3     
  Branches      2649      2651    +2     
=========================================
+ Hits          9354      9357    +3     
Impacted Files Coverage Δ
components/mentions/index.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit 8fd6ae5 into ant-design:master Nov 25, 2022
li-jia-nan pushed a commit that referenced this pull request Nov 25, 2022
* feat: fix support options

* feat: update package
This was referenced Nov 25, 2022
@heiyu4585 heiyu4585 deleted the fix-mentions-options branch December 22, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants