Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect Select and Pagination text color for dark theme #38979

Merged
merged 3 commits into from Nov 25, 2022

Conversation

Dunqing
Copy link
Contributor

@Dunqing Dunqing commented Nov 25, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close: #38805

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Select and Pagination incorrect text color in dark theme.
🇨🇳 Chinese 修复 Select 和 Pagination 在暗色主题下文字颜色不正确。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

Co-authored-by: afc163 <afc163@gmail.com>
@Dunqing Dunqing changed the title fix: incorrect select text for dark theme fix: incorrect Select and Pagination text color for dark theme Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b68154f) compared to base (d989a4e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38979   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          545       545           
  Lines         9354      9357    +3     
  Branches      2649      2651    +2     
=========================================
+ Hits          9354      9357    +3     
Impacted Files Coverage Δ
components/mentions/index.tsx 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 963f95f into ant-design:master Nov 25, 2022
li-jia-nan pushed a commit that referenced this pull request Nov 25, 2022
* fix: incorrect select text for dark theme

* Update components/select/style/index.tsx

Co-authored-by: afc163 <afc163@gmail.com>

* fix: same

Co-authored-by: afc163 <afc163@gmail.com>
This was referenced Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select search text color didn't follow theme config
3 participants