Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): fix row list incorrect when filter column may have been removed or use a new key #38982

Merged
merged 3 commits into from Nov 25, 2022

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Nov 25, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

fix #38978

📝 Changelog

Language Changelog
🇺🇸 English Fix the problem that the old filter state still takes effect when the list filter column changes
🇨🇳 Chinese 修复过滤列被移除后过滤效果仍然影响列表数据的问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

@github-actions
Copy link
Contributor

Size Change: +82 B (0%)

Total Size: 901 kB

Filename Size Change
./dist/antd-with-locales.min.js 479 kB +48 B (0%)
./dist/antd.min.js 422 kB +34 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (ac57e86) compared to base (963f95f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38982   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          545       545           
  Lines         9357      9361    +4     
  Branches      2651      2653    +2     
=========================================
+ Hits          9357      9361    +4     
Impacted Files Coverage Δ
components/table/hooks/useFilter/index.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Member

afc163 commented Nov 25, 2022

来个用例?

@moling1234
Copy link

@yoyo837
Copy link
Contributor Author

yoyo837 commented Nov 25, 2022

来个用例?

Done.

@afc163 afc163 merged commit e77b59a into master Nov 25, 2022
@afc163 afc163 deleted the fix-reset-columns-filter-err branch November 25, 2022 07:13
@yoyo837 yoyo837 changed the title fix(table): Fix reset columns filter err fix(table): fix row list incorrect when filter column may have been removed or use a new key Nov 25, 2022
li-jia-nan pushed a commit that referenced this pull request Nov 25, 2022
* fix(table): fix filter state when reset columns

* fix(table): Fix the problem that the old filter state still takes effect when the list filter column changes

* test: add test case
This was referenced Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

antd table 进行列筛选时后,更新 columns, datasource, 导致页面显示错误
3 participants