[v4] Fix(types): external module type error (CompoundedComponent) #39058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## 4.x-stable #39058 +/- ##
============================================
Coverage 100.00% 100.00%
============================================
Files 450 450
Lines 8333 8333
Branches 2539 2539
============================================
Hits 8333 8333
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wangcch
force-pushed
the
fix-v4-compounded-component-type
branch
from
52ee67b
to
9c35b3f
Compare
codeball-ai-writer
bot
added
codeball:needs-careful-review
and removed
codeball:needs-review
labels
wangcch
changed the title
|
Rebase please. |
wangcch
force-pushed
the
fix-v4-compounded-component-type
branch
from
9c35b3f
to
9bdf478
Compare
Done |
yoyo837
reviewed
Jan 3, 2023
components/alert/index.tsx
Outdated
| @@ -69,7 +69,7 @@ interface IconNodeProps { | |||
| description: AlertProps['description']; | |||
| } | |||
|
|
|||
| const IconNode: React.FC<IconNodeProps> = props => { | |||
| const IconNode: React.FC<IconNodeProps> = (props) => { | |||
There was a problem hiding this comment.
这个之前的 PR 有说明，是 .prettierrc ("arrowParens": "avoid") 和 rome js config 冲突
There was a problem hiding this comment.
git hook: rome format when pre-commit
There was a problem hiding this comment.
剩下的都是必要修改行，随带按照 rome config 修改了
wangcch
force-pushed
the
fix-v4-compounded-component-type
branch
from
9bdf478
to
7923109
Compare
yoyo837
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#38666
💡 Background and solution
Wrong type for
CompoundedComponentfrom external moduleFor V4.x
📝 Changelog
CompoundedComponent的组建的类型报错☑️ Self-Check before Merge