fix(Anchor): fix highlighting failure when dynamically updating items #40743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #40743 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 606 606
Lines 10289 10287 -2
Branches 2790 2790
=========================================
- Hits 10289 10287 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
来个测试用例？ |
|
一个经典 useEvent 场景 |
|
看样子是我之前重构 FC 改出问题了…… |
React 的依赖项，还是挺坑的~ |
|
来个测试用例？ |
@MadCcc 求助攻~ |
|
any update? |
li-jia-nan
approved these changes
Mar 10, 2023
|
本地试了一下没有问题，先 merge 了，测试用例我单独开个 PR 补一下吧 |
|
Bug 最近很多哦，有很多很表面的bug哟， 注意下代码质量哟 |
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 4, 2023
…ant-design#40743) * fix(Anchor): fix highlighting failure when dynamically updating items * fix: improve test coverage * refactor(Anchor): use `useEvent` instead
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
…ant-design#40743) * fix(Anchor): fix highlighting failure when dynamically updating items * fix: improve test coverage * refactor(Anchor): use `useEvent` instead
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
…ant-design#40743) * fix(Anchor): fix highlighting failure when dynamically updating items * fix: improve test coverage * refactor(Anchor): use `useEvent` instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
复现地址
复现步骤：
📝 Changelog
☑️ Self-Check before Merge