Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(input): Added Space.Compact recommendations #41080

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

Yuiai01
Copy link
Contributor

@Yuiai01 Yuiai01 commented Mar 6, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #41078

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Added Space.Compact recommendations
🇨🇳 Chinese 添加 Space.Compact 的推荐

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (3266635) 100.00% compared to head (af5f7af) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #41080   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          610       610           
  Lines        10440     10442    +2     
  Branches      2842      2843    +1     
=========================================
+ Hits         10440     10442    +2     
Impacted Files Coverage Δ
components/input/Group.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kiner-tang kiner-tang requested a review from zombieJ March 6, 2023 06:33
@MadCcc
Copy link
Member

MadCcc commented Mar 6, 2023

把 demo 里的 Input.Group 换成 Compact,下面的 API 表明一下废弃

@Yuiai01 Yuiai01 force-pushed the docs branch 2 times, most recently from 6df68fc to 7365540 Compare March 8, 2023 15:28
@MadCcc
Copy link
Member

MadCcc commented Mar 9, 2023

Input.Group 有 deprecate warning 吗,没有的话也加一下吧

@zombieJ zombieJ merged commit 2bc1698 into ant-design:master Mar 9, 2023
@zombieJ zombieJ mentioned this pull request Mar 13, 2023
16 tasks
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 4, 2023
* docs(input): Added Space.Compact recommendations

* chore: warning for deprecated

---------

Co-authored-by: 二货机器人 <smith3816@gmail.com>
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* docs(input): Added Space.Compact recommendations

* chore: warning for deprecated

---------

Co-authored-by: 二货机器人 <smith3816@gmail.com>
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* docs(input): Added Space.Compact recommendations

* chore: warning for deprecated

---------

Co-authored-by: 二货机器人 <smith3816@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input.Group size=large or size=small is not honored for the button
5 participants