Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upload in React 18 sync problem #41082

Merged
merged 2 commits into from
Mar 6, 2023
Merged

fix: Upload in React 18 sync problem #41082

merged 2 commits into from
Mar 6, 2023

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Mar 6, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

这个 PR 只修复了非受控模式,没有修复受控模式

📝 Changelog

Language Changelog
🇺🇸 English fix: Upload in React 18 sync problem
🇨🇳 Chinese fix: 修复 react18 批处理带来的 break change

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 374.38 KB
./dist/antd-with-locales.min.js 431.32 KB (+1 B 🔺)

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (55166d4) 100.00% compared to head (af6d237) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #41082   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          610       610           
  Lines        10438     10439    +1     
  Branches      2842      2842           
=========================================
+ Hits         10438     10439    +1     
Impacted Files Coverage Δ
components/upload/utils.ts 100.00% <ø> (ø)
components/upload/Upload.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jia-nan li-jia-nan requested a review from zombieJ March 6, 2023 07:55
@li-jia-nan li-jia-nan merged commit c38108a into master Mar 6, 2023
@li-jia-nan li-jia-nan deleted the flushSync branch March 6, 2023 08:38
@zombieJ zombieJ mentioned this pull request Mar 13, 2023
16 tasks
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 4, 2023
* fix: Upload in React 18 sync problem

* test: add test case
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* fix: Upload in React 18 sync problem

* test: add test case
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* fix: Upload in React 18 sync problem

* test: add test case
@zombieJ zombieJ mentioned this pull request Jun 26, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload组件在受控状态时, 同时上传多个文件, onChange里的fileList内容不正确
2 participants