Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): fix the layout/table moves when dragging elements to the right #41139

Merged
merged 5 commits into from
Mar 14, 2023

Conversation

hoho2017
Copy link
Contributor

@hoho2017 hoho2017 commented Mar 9, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

按住元素拖拽时,发生往右移动时会使table的宽度变长而发生神奇的现象,原因是元素的translate3d的x在拖拽时发生变化导致的,所以得将x设为0,只需要在y方向上变化移动就好了。

📝 Changelog

Language Changelog
🇺🇸 English 🐞 The layout/table moves when dragging elements to the right
🇨🇳 Chinese 🐞 拖拽排序拖动元素一直往右移时布局发生移动问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3266635) 100.00% compared to head (2bcfdeb) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #41139   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          610       610           
  Lines        10440     10440           
  Branches      2842      2842           
=========================================
  Hits         10440     10440           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jia-nan li-jia-nan merged commit cf8a0b0 into ant-design:master Mar 14, 2023
@PeachScript PeachScript mentioned this pull request Mar 20, 2023
20 tasks
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
…right (ant-design#41139)

* fix: 稳定格式错乱啦

* Update drag-sorting-handler.tsx

* Update drag-sorting-handler.tsx

---------

Co-authored-by: zhanghaoqiang <zhanghq7458@joyowo.com>
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
…right (ant-design#41139)

* fix: 稳定格式错乱啦

* Update drag-sorting-handler.tsx

* Update drag-sorting-handler.tsx

---------

Co-authored-by: zhanghaoqiang <zhanghq7458@joyowo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants