style(InputNumber): Fixed font highlighting when disabled #41167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MadCcc
approved these changes
Mar 10, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #41167 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 610 610
Lines 10488 10452 -36
Branches 2867 2849 -18
=========================================
- Hits 10488 10452 -36
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
编译挂了，重新 rebase 一下~ |
Yuiai01
force-pushed
the
input-number-style
branch
from
cb3d29d
to
2461b10
Compare
好，重新 rebase 了~ |
afc163
approved these changes
Mar 10, 2023
Wxh16144
added a commit
to Wxh16144-forks/ant-design
that referenced
this pull request
Mar 10, 2023
…t-design#41167)" This reverts commit 38b47f6.
afc163
pushed a commit
that referenced
this pull request
Mar 11, 2023
* fix: ConfirmDialog passing wrong footer prop * test: add case * fix: fix modal accidental rendering of footer * test: update snapshot * Revert "style(InputNumber): Fixed font highlighting when disabled (#41167)" This reverts commit 38b47f6. * test: update snapshot * Align components/input-number/style/index.ts with master --------- Co-authored-by: Karlo Sudec <karlo.sudec@brainit.agency> Co-authored-by: wuxh <wxh1220@gmail.com>
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 4, 2023
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 4, 2023
* fix: ConfirmDialog passing wrong footer prop * test: add case * fix: fix modal accidental rendering of footer * test: update snapshot * Revert "style(InputNumber): Fixed font highlighting when disabled (ant-design#41167)" This reverts commit 38b47f6. * test: update snapshot * Align components/input-number/style/index.ts with master --------- Co-authored-by: Karlo Sudec <karlo.sudec@brainit.agency> Co-authored-by: wuxh <wxh1220@gmail.com>
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
* fix: ConfirmDialog passing wrong footer prop * test: add case * fix: fix modal accidental rendering of footer * test: update snapshot * Revert "style(InputNumber): Fixed font highlighting when disabled (ant-design#41167)" This reverts commit 38b47f6. * test: update snapshot * Align components/input-number/style/index.ts with master --------- Co-authored-by: Karlo Sudec <karlo.sudec@brainit.agency> Co-authored-by: wuxh <wxh1220@gmail.com>
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
* fix: ConfirmDialog passing wrong footer prop * test: add case * fix: fix modal accidental rendering of footer * test: update snapshot * Revert "style(InputNumber): Fixed font highlighting when disabled (ant-design#41167)" This reverts commit 38b47f6. * test: update snapshot * Align components/input-number/style/index.ts with master --------- Co-authored-by: Karlo Sudec <karlo.sudec@brainit.agency> Co-authored-by: wuxh <wxh1220@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #41159
💡 Background and solution
InputNumber 在状态为 disabled 时，value 值高亮，下面为修复前后对比：
修复前：
修复后：
📝 Changelog
☑️ Self-Check before Merge