fix: ConfirmDialog passing wrong footer prop #41173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chore: add test
Wxh16144
previously requested changes
Mar 10, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #41173 +/- ##
===========================================
- Coverage 100.00% 99.99% -0.01%
===========================================
Files 610 610
Lines 10488 10452 -36
Branches 2867 2849 -18
===========================================
- Hits 10488 10451 -37
- Misses 0 1 +1
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
afc163
approved these changes
Mar 11, 2023
afc163
approved these changes
Mar 11, 2023
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 4, 2023
* fix: ConfirmDialog passing wrong footer prop * test: add case * fix: fix modal accidental rendering of footer * test: update snapshot * Revert "style(InputNumber): Fixed font highlighting when disabled (ant-design#41167)" This reverts commit 38b47f6. * test: update snapshot * Align components/input-number/style/index.ts with master --------- Co-authored-by: Karlo Sudec <karlo.sudec@brainit.agency> Co-authored-by: wuxh <wxh1220@gmail.com>
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
* fix: ConfirmDialog passing wrong footer prop * test: add case * fix: fix modal accidental rendering of footer * test: update snapshot * Revert "style(InputNumber): Fixed font highlighting when disabled (ant-design#41167)" This reverts commit 38b47f6. * test: update snapshot * Align components/input-number/style/index.ts with master --------- Co-authored-by: Karlo Sudec <karlo.sudec@brainit.agency> Co-authored-by: wuxh <wxh1220@gmail.com>
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
* fix: ConfirmDialog passing wrong footer prop * test: add case * fix: fix modal accidental rendering of footer * test: update snapshot * Revert "style(InputNumber): Fixed font highlighting when disabled (ant-design#41167)" This reverts commit 38b47f6. * test: update snapshot * Align components/input-number/style/index.ts with master --------- Co-authored-by: Karlo Sudec <karlo.sudec@brainit.agency> Co-authored-by: wuxh <wxh1220@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
Fixes #41170
💡 Background and solution
<ConfirmDialog>component was passing an empty string as afooterprop to the<Dialog>component.That was wrong as
<Dialog>component is rendering that empty string in a<div>element wrapper that has a margin-top attribute as shown in the screenshot in the referenced issue.<ConfirmDialog>should pass anullvalue for footer prop. That way a footer wrapperdivwon't be rendered.BEFORE CHANGE:
AFTER CHANGE:
📝 Changelog
confirm()to open a Modalconfirm()打开 Modal 时下边距过大的问题☑️ Self-Check before Merge