type: update React.forwardRef type #41189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
li-jia-nan
commented
Mar 13, 2023
components/radio/radio.tsx
Outdated
| @@ -84,7 +84,7 @@ const InternalRadio: React.ForwardRefRenderFunction<HTMLElement, RadioProps> = ( | |||
| ); | |||
| }; | |||
|
|
|||
| const Radio = React.forwardRef<unknown, RadioProps>(InternalRadio); | |||
| const Radio = React.forwardRef<HTMLElement, RadioProps>(InternalRadio); | |||
There was a problem hiding this comment.
在 feature 分支中，这里的泛型类型是 CheckboxRef，到时候进行 Branch merge 的时候可能会出现冲突，如果冲突直接采用 feature 中的类型即可。
There was a problem hiding this comment.
那这里不改了吧，如果有用户依赖了显式的 HTMLElement，到时候发 minor 又会 break
There was a problem hiding this comment.
这里回滚了，正好发现另一个地方有问题，顺便改掉了
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #41189 +/- ##
==========================================
- Coverage 99.99% 99.99% -0.01%
==========================================
Files 610 610
Lines 10486 10450 -36
Branches 2865 2847 -18
==========================================
- Hits 10485 10449 -36
Misses 1 1
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
li-jia-nan
commented
Mar 14, 2023
afc163
approved these changes
Mar 14, 2023
zombieJ
approved these changes
Mar 14, 2023
20 tasks
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 4, 2023
* type: update React.forwardRef type * type: revert
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
* type: update React.forwardRef type * type: revert
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
* type: update React.forwardRef type * type: revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
type: update React.forwardRef type #41188
在 feature 分支中，这里的泛型类型是
CheckboxRef，到时候进行 Branch merge 的时候可能会出现冲突，如果冲突直接采用 feature 中的类型即可。📝 Changelog
☑️ Self-Check before Merge