Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BreadcrumbItemType missing onClick func #41283

Merged
merged 6 commits into from
Mar 17, 2023
Merged

Conversation

acyza
Copy link
Contributor

@acyza acyza commented Mar 16, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #41274

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Implement onClick in item props
🇨🇳 Chinese 补充 item属性中的onClick的缺失

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

@zombieJ zombieJ changed the title feat: BreadcrumbItemType add onClick bug: BreadcrumbItemType missing onClick func Mar 16, 2023
@zombieJ zombieJ changed the title bug: BreadcrumbItemType missing onClick func fix: BreadcrumbItemType missing onClick func Mar 16, 2023
@zombieJ
Copy link
Member

zombieJ commented Mar 16, 2023

CI failed. Could you help to rebase master?

@acyza
Copy link
Contributor Author

acyza commented Mar 16, 2023

最后一个合并的ci也是挂在这图片

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (39adae8) 100.00% compared to head (2e736ae) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #41283   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          610       610           
  Lines        10494     10452   -42     
  Branches      2868      2848   -20     
=========================================
- Hits         10494     10452   -42     
Impacted Files Coverage Δ
components/breadcrumb/Breadcrumb.tsx 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@heiyu4585
Copy link
Contributor

className 也缺失了,可以帮忙顺便补充一下 吗

@zombieJ zombieJ merged commit 6c8082a into ant-design:master Mar 17, 2023
trongtai37 pushed a commit to trongtai37/ant-design that referenced this pull request Mar 18, 2023
* feat: BreadcrumbItemType add onClick

* chore: update

* fix: 补充className

* chore: update
@PeachScript PeachScript mentioned this pull request Mar 20, 2023
20 tasks
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* feat: BreadcrumbItemType add onClick

* chore: update

* fix: 补充className

* chore: update
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* feat: BreadcrumbItemType add onClick

* chore: update

* fix: 补充className

* chore: update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

给面包屑添加onClick事件后,点击不触发事件
3 participants