Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anchor): ink correct switch direction #41317

Merged
merged 8 commits into from
Mar 19, 2023
Merged

Conversation

acyza
Copy link
Contributor

@acyza acyza commented Mar 17, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #41246

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English ink correct switch direction
🇨🇳 Chinese ink正确切换方向

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2023

@acyza acyza force-pushed the anchor branch 3 times, most recently from 9093fda to 5c80cf6 Compare March 17, 2023 20:25
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0f1bc24) 100.00% compared to head (8569621) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #41317   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          610       610           
  Lines        10452     10454    +2     
  Branches      2848      2852    +4     
=========================================
+ Hits         10452     10454    +2     
Impacted Files Coverage Δ
components/anchor/Anchor.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@acyza acyza closed this Mar 17, 2023
@acyza acyza reopened this Mar 17, 2023
@acyza acyza closed this Mar 17, 2023
@acyza acyza reopened this Mar 17, 2023
@acyza acyza requested a review from yoyo837 March 18, 2023 16:28
@afc163 afc163 merged commit 16f0b57 into ant-design:master Mar 19, 2023
@yoyo837 yoyo837 mentioned this pull request Mar 19, 2023
20 tasks
@PeachScript PeachScript mentioned this pull request Mar 20, 2023
20 tasks
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* fix(anchor): ink correct switch direction

* chore(anchor): fix test error

* chore(anchor): fix test error

* chore: test

* chore: test

* chore: test

* chore: update
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* fix(anchor): ink correct switch direction

* chore(anchor): fix test error

* chore(anchor): fix test error

* chore: test

* chore: test

* chore: test

* chore: update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anchor component CSS breaks when switching the direction between horizontal and vertical
3 participants