fix(input): missing rtl className for count in TextArea #41319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kiner-tang
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #41319 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 610 610
Lines 10452 10452
Branches 2848 2848
=========================================
Hits 10452 10452
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
yoyo837
reviewed
Mar 18, 2023
| @@ -104,6 +104,7 @@ const TextArea = forwardRef<TextAreaRef, TextAreaProps>( | |||
| countWrapper: classNames( | |||
| `${prefixCls}-textarea`, | |||
| `${prefixCls}-textarea-show-count`, | |||
| { [`${prefixCls}-textarea-show-count-rtl`]: direction === 'rtl' }, | |||
There was a problem hiding this comment.
Suggested change
| { [`${prefixCls}-textarea-show-count-rtl`]: direction === 'rtl' }, | |
| `${prefixCls}-textarea-show-count-rtl`: direction === 'rtl', |
How about this?
There was a problem hiding this comment.
We can't do that, we need the object to be able to use our direction condition
afc163
approved these changes
Mar 19, 2023
20 tasks
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
When
showCountis used, it should be positioned at the end of the elementExamples of the problem:
📝 Changelog
showCount.showCount时修复了 RTL 模式下 Input.TextArea 的位置。☑️ Self-Check before Merge