-
-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DatePicker & Calendar export generate function directly #41773
Conversation
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #41773 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 614 615 +1
Lines 10514 10525 +11
Branches 2881 2881
=========================================
+ Hits 10514 10525 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…sign#41773) * feat: DatePicker.gen support * test: update snapshot * docs: update docs
…sign#41773) * feat: DatePicker.gen support * test: update snapshot * docs: update docs
@zombieJ said features are released at the end of the month, but it's now 5 days into May, and I still don't see this. When will this be released? I just want my theme to work properly in NextJS when using Date Picker and Calendar. |
@devuxer, I still work with DatePicker |
@zombieJ, I understand. Thanks for the update! |
Hi @zombieJ , Sorry to message again, but do you think this feature will be released by the end of the month? Or do you have a workaround? This is a blocker for me. Thank you! |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
resolve #41749
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at e1fff21
This pull request adds support for custom date libraries in the
DatePicker
andCalendar
components. It introduces thegeneratePicker
andgenerateCalendar
methods as static properties on the components, which allow users to create custom components with different date libraries and configurations. It also updates the documentation and tests for these features.🔍 Walkthrough
🤖 Generated by Copilot at e1fff21
generatePicker
andgenerateCalendar
methods as static properties ofDatePicker
andCalendar
components respectively, to allow users to create custom components with different date libraries (link, link, link, link)generatePicker
andgenerateCalendar
functions in the test files and the documentation files to use the methods from theDatePicker
andCalendar
components instead (link, link, link, link, link, link, link, link, link, link, link)luxonGenerateConfig
from therc-picker
library in the documentation files to use thelib
directory instead of thees
directory, for consistency with the other date library imports (link, link)generatePicker
module in thecomponents/date-picker/index.ts
file, to group the types together and follow the alphabetical order (link)_InternalPanelDoNotUseOrYouWillBeFired
and_InternalRangePanelDoNotUseOrYouWillBeFired
properties to theDatePicker
component after the type casting, to avoid type errors (link)