Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DatePicker support changeOnBlur #42168

Merged
merged 8 commits into from
May 9, 2023
Merged

feat: DatePicker support changeOnBlur #42168

merged 8 commits into from
May 9, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 6, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

resolves #42034

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English DatePicker support changeOnBlur to trigger change event without clicking confirm.
🇨🇳 Chinese DatePicker 支持 changeOnBlur 以允许不点击确认按钮,在失去焦点时也能触发 change 事件。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at b874bde

Added changeOnBlur prop to RangePicker component and updated its demos and documentation. Bumped rc-picker dependency to version 3.7.2.

🔍 Walkthrough

🤖 Generated by Copilot at b874bde

  • Add changeOnBlur prop to RangePicker component to trigger change event on blur (link, link, link, link)
  • Update select-in-range demo and markdown files to show usage of changeOnBlur prop (link, link)
  • Reorder import statements in select-in-range.tsx to follow convention (link)

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

@socket-security
Copy link

socket-security bot commented May 6, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
rc-picker@3.7.4 None +0 zombiej

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 377.18 KB (+250 B 🔺)
./dist/antd-with-locales.min.js 436.45 KB (+264 B 🔺)

@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (314b93b) 100.00% compared to head (36aa8c5) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #42168   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          619       619           
  Lines        10568     10568           
  Branches      2885      2885           
=========================================
  Hits         10568     10568           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

.eslintcache Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

咦,为啥这个文件会更新呢?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件是不是不应该提交上来?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该gitignore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

奇怪,看起来是新增的?加到 ignore 里去

Copy link
Contributor

@yoyo837 yoyo837 May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint-webpack-plugin 4.0.1 的cache默认是true了

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

但我没找到这个依赖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants