Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(card): tab size extend card size(#42176) #42183

Merged
merged 2 commits into from
May 7, 2023

Conversation

huangkairan
Copy link
Contributor

@huangkairan huangkairan commented May 6, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#42176

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English feat(card):The size of Tab defaults to inherit the size of Card
🇨🇳 Chinese feat(card): Tab 的 size 默认继承 Card 的 size

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at aaedddc

This pull request adds a new feature to allow customizing the tab size for Card components, and updates the test file index.test.tsx to cover this feature.

🔍 Walkthrough

🤖 Generated by Copilot at aaedddc

  • Add a new feature to support different tab sizes for cards (link)
    • Remove the redundant declaration of mergedSize that was moved to line 117 (link)
  • Add a new test case to verify the new feature (link)

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

@afc163 afc163 changed the title feat(card): tab size extend card size(#42176) fix(card): tab size extend card size(#42176) May 6, 2023
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a8c3eb4) 100.00% compared to head (fb1644c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #42183   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          617       617           
  Lines        10541     10542    +1     
  Branches      2881      2882    +1     
=========================================
+ Hits         10541     10542    +1     
Impacted Files Coverage Δ
components/card/Card.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 7006b37 into ant-design:master May 7, 2023
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants