-
-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Space.Compact UI bug #42199
Merged
Merged
fix: Space.Compact UI bug #42199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when the componentSize is set
Please update jest snapshot. |
Thank you for updating the snapshot for me! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #42199 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 619 617 -2
Lines 11047 10529 -518
Branches 3079 2876 -203
==========================================
- Hits 11047 10529 -518
☔ View full report in Codecov by Sentry. |
zombieJ
approved these changes
May 9, 2023
PR 标题应该先改对再合并的。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link #41876
fix #41876
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at e44f7d0
Added support for
ConfigProvider
size inSpace.Compact
component and added corresponding test cases. Updatedcomponents/space/Compact.tsx
andcomponents/space/__tests__/space-compact.test.tsx
files.🔍 Walkthrough
🤖 Generated by Copilot at e44f7d0
ConfigProvider
component to test cases forSpace.Compact
component (link)Space.Compact
component inherits size fromConfigProvider
component ifsize
prop is not specified (link)size
prop ofSpace.Compact
component overridescomponentSize
property ofConfigProvider
component if both are specified (link)SizeContext
from../config-provider/SizeContext
to accesscomponentSize
property fromConfigProvider
component inSpace.Compact
component (link)size
prop ofSpace.Compact
component to usesizeInContext
variable, which is the value ofcomponentSize
property fromConfigProvider
component or'middle'
by default (link)