Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix Pagination size small of CP #42206

Merged
merged 2 commits into from
May 8, 2023
Merged

chore: fix Pagination size small of CP #42206

merged 2 commits into from
May 8, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 8, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

resolve #42205

📝 Changelog

Language Changelog
🇺🇸 English Fix ConfigProvider size prop not work on Pagination.
🇨🇳 Chinese 修复 ConfigProvider size 对 Pagination 无效的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at d3001ad

Refactor Pagination component to use global SizeContext and add customizeSize prop. Add test case for configProvider component with componentSize prop.

🔍 Walkthrough

🤖 Generated by Copilot at d3001ad

  • Use SizeContext to provide global size for Pagination component (link, link, link)
  • Add test case for configProvider component with small size (link)

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 376.17 KB (+10 B 🔺)
./dist/antd-with-locales.min.js 435.41 KB (+9 B 🔺)

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3414e45) 100.00% compared to head (7ca80b3) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #42206   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          617       617           
  Lines        10542     10545    +3     
  Branches      2882      2883    +1     
=========================================
+ Hits         10542     10545    +3     
Impacted Files Coverage Δ
components/locale/bg_BG.ts 100.00% <100.00%> (ø)
components/pagination/Pagination.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit 8c725ca into master May 8, 2023
88 checks passed
@zombieJ zombieJ deleted the fix-cp branch May 8, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigProvider 配置 componentSize 对 Pagination 不生效
3 participants