fix: Added bgColor attribute to fix the problem that the background c… #42214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
改到 feature branch 吧，另外加个测试用例 |
|
|
|
rebase 一下，你把 master 的改动带过来了，master 的 commit 不应该出现在这里 |
|
|
…olor of the QR code is displayed incorrectly when downloading
好了。。 |
|
不会有这个问题 那个容器是用户自己写的div，下载的只是二维码的真实图片内容 |
|
现在应该好了，第一次提pr不懂操作不好意思= = |
|
同步一下上游分支 |
|
lint 挂了 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #42214 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 619 619
Lines 10568 10569 +1
Branches 2885 2886 +1
=========================================
+ Hits 10568 10569 +1
☔ View full report in Codecov by Sentry. |
|
背景是 antd 提供的，也要考虑进去。现在的 demo 和线上的就有区别 |
li-jia-nan
reviewed
May 9, 2023
li-jia-nan
reviewed
May 9, 2023
li-jia-nan
reviewed
May 9, 2023
li-jia-nan
reviewed
May 9, 2023
|
CI 挂了，需要更新一下 snap |
li-jia-nan
reviewed
May 9, 2023
afc163
reviewed
May 9, 2023
li-jia-nan
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
color of the QR code is displayed incorrectly when downloading
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #42213
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 5a2bffc
Added a new
bgColorprop to the QRCode component to enable customizing the background color of the QR code. Updated the component examples, interface, and documentation accordingly.🔍 Walkthrough
🤖 Generated by Copilot at 5a2bffc
bgColorprop to QRCode component to customize the background color of the QRCode (link, link)bgColorprop to QRCodeGenerator options and useMemo dependency array incomponents/qrcode/index.tsxto render the QRCode with the correct background color (link)bgColorprop in English and Chinese API sections ofcomponents/qrcode/index.en-US.mdandcomponents/qrcode/index.zh-CN.mdwith default value oftransparent(link, link)styleprop bybgColorprop in QRCode component examples incomponents/qrcode/demo/customColor.tsxandcomponents/qrcode/demo/customColor.mdto demonstrate how to use the new prop (link, link)components/qrcode/demo/customColor.tsxto follow convention of importing React first (link)