fix: Popover display empty div when title and content is null #42217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
请同步修复下4.x版本 |
再给4.x-stable分支发PR即可 |
yoyo837
reviewed
May 8, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #42217 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 617 617
Lines 10545 10544 -1
Branches 2883 2883
=========================================
- Hits 10545 10544 -1
☔ View full report in Codecov by Sentry. |
|
加一个 test case~ |
li-jia-nan
reviewed
May 8, 2023
|
同步一下上游分支 |
afc163
reviewed
May 8, 2023
已加，原测试案例写的有点问题，顺带修复了 |
等这个review无问题后，我这边再发起一个到4.x的PR |
li-jia-nan
approved these changes
May 8, 2023
hairgc
added a commit
to hairgc/ant-design
that referenced
this pull request
May 9, 2023
…sign#42217) * fix: Popover display empty div when title and content is null * test: Popover add test * lint: remove useless block statement --------- Co-authored-by: MaHui <mahuiyoung@cmbchina.com> (cherry picked from commit 4271ff0)
afc163
added a commit
that referenced
this pull request
May 10, 2023
* fix: Popover display empty div when title and content is null (#42217) * fix: Popover display empty div when title and content is null * test: Popover add test * lint: remove useless block statement --------- Co-authored-by: MaHui <mahuiyoung@cmbchina.com> (cherry picked from commit 4271ff0) * lint: fix Popover test lint error * lint: fix Popover test lint error * improvement: Popover overlay * lint: fix Popover test lint error * Update package.json --------- Co-authored-by: MaHui <mahuiyoung@cmbchina.com> Co-authored-by: afc163 <afc163@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #42216
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at eab7c90
Simplify
Popovercomponent logic and rendering. Remove redundanttitleandcontentprops fromOverlayPropsand renderOverlayonly when it has content.🔍 Walkthrough
🤖 Generated by Copilot at eab7c90
titleandcontentinOverlayPropsinterface (link)Overlaycomponent inPopovercomponent based ontitleorcontent(link)