Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align motion follow popup point #42225

Merged
merged 2 commits into from
May 8, 2023
Merged

chore: align motion follow popup point #42225

merged 2 commits into from
May 8, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 8, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Adjust Tooltip motion that will auto detect best match transform origin.
🇨🇳 Chinese 调整 Tooltip 动画,现在弹出位置会动态从箭头方向弹出。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 37dd603

Improved tooltip component alignment, animation, and demo using rc-trigger dependency. Removed unused code and fixed import order in tooltip files.

🔍 Walkthrough

🤖 Generated by Copilot at 37dd603

  • Update @rc-component/trigger dependency to 1.12.0 in package.json to improve Tooltip functionality and animation (link)
  • Remove onPopupAlign function and prop from Tooltip and RcTooltip components in components/tooltip/index.tsx as they are no longer needed (link, link)
  • Add transformOrigin style to genTooltipStyle function in components/tooltip/style/index.ts to use CSS variables set by rc-trigger for smoother tooltip animation (link)
  • Change import order of mergeToken and genPresetColor functions in components/tooltip/style/index.ts to follow alphabetical order (link)
  • Remove unused AlignType type from import statement in components/tooltip/index.tsx (link)
  • Modify Tooltip component in shift.tsx demo to use trigger="click" and defaultOpen props instead of open prop for better interactivity and consistency (link)

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 376.17 KB (-134 B 🔽)
./dist/antd-with-locales.min.js 435.41 KB (-138 B 🔽)

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a4669ac) 100.00% compared to head (3384ed6) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #42225   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          617       617           
  Lines        10544     10528   -16     
  Branches      2883      2876    -7     
=========================================
- Hits         10544     10528   -16     
Impacted Files Coverage Δ
components/tooltip/index.tsx 100.00% <ø> (ø)
components/tooltip/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit f4858ff into master May 8, 2023
88 checks passed
@zombieJ zombieJ deleted the fix-align-motion branch May 8, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants