fix: Progress throws warning findDOMNode is deprecated in StrictMode
#42241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #42241 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 618 618
Lines 10539 10539
Branches 2879 2879
=========================================
Hits 10539 10539
☔ View full report in Codecov by Sentry. |
li-jia-nan
approved these changes
May 10, 2023
afc163
reviewed
May 10, 2023
| ); | ||
| expect(errSpy).not.toHaveBeenCalledWith( | ||
| 'Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of DomWrapper which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node', | ||
| ); |
There was a problem hiding this comment.
这个 warning 过于完整了，如果 react 改个字符就对不上了。
There was a problem hiding this comment.
.not.toHaveBeenCalledWith(expect.stringContaining('findDOMNode is deprecated in StrictMode'))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
findDOMNode is deprecated in StrictMode☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 33029d7
Added ref forwarding and a new test case for the
Progresscomponent. This improves the component's compatibility with React strict mode and other components that use refs, such asTooltip.🔍 Walkthrough
🤖 Generated by Copilot at 33029d7
Progresscomponent inReact.forwardRefand passrefprop todivelement to support ref forwarding (link,link,link,link)Tooltipcomponent fromantdand add test case forProgresscomponent wrapped inTooltipcomponent to check for no strict mode warning (link,link)ProgressTypestype fromprogress.tsxtoindex.test.tsxto avoid circular dependency issue (link,link)