Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix InputNumber out of range style error #42250

Merged

Conversation

dark9wesley
Copy link
Contributor

@dark9wesley dark9wesley commented May 10, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#42243

💡 Background and solution

详情请查看issue

加了个选择器,增加了权重,使样式不会被inputNumber默认样式覆盖

📝 Changelog

Language Changelog
🇺🇸 English fix inputNumber out of range style does not take effect
🇨🇳 Chinese 修复 inputNumber out of range 样式不生效的问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 9a2328c

Fixed a style bug and added a test case for InputNumber component. The bug caused the input element to have the wrong color when the component is disabled and out of range. The test case verified the error class name when the component is controlled and out of range.

🔍 Walkthrough

🤖 Generated by Copilot at 9a2328c

  • Import Button component to use in a new test case for InputNumber (link)
  • Add a test case to check the rendering of InputNumber when the controlled mode number is out of range (link)
  • Modify the style rule for the ant-input-number-out-of-range class name in components/input-number/style/index.ts (link)

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6d0acb0) 100.00% compared to head (9a2328c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #42250   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          617       618    +1     
  Lines        10541     10541           
  Branches      2881      2880    -1     
=========================================
  Hits         10541     10541           
Impacted Files Coverage Δ
components/input-number/style/index.ts 100.00% <ø> (ø)

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 changed the title Fix/input number out of range style error style: fix InputNumber out of range style error May 10, 2023
@afc163 afc163 merged commit 3a96400 into ant-design:master May 10, 2023
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants