Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Space support ref #42266

Merged
merged 1 commit into from
May 11, 2023
Merged

Feat: Space support ref #42266

merged 1 commit into from
May 11, 2023

Conversation

RedJue
Copy link
Member

@RedJue RedJue commented May 11, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Make Space support ref
🇨🇳 Chinese Space 组件支持 ref

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 7b83d36

This pull request adds ref support to the Space component, allowing users to access the underlying DOM element. It also updates the type definition and the test suite for the Space component.

🔍 Walkthrough

🤖 Generated by Copilot at 7b83d36

  • Wrap Space component with React.forwardRef and pass ref prop to div element (link, link, link, link)
  • Update type definition of CompoundedComponent to match forward ref component (link)
  • Reorder import statements in components/space/index.tsx (link)
  • Add test case for ref prop of Space component in components/space/__tests__/index.test.tsx (link)

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (34af3ec) 100.00% compared to head (7b83d36) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #42266   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          619       619           
  Lines        10570     10570           
  Branches      2886      2886           
=========================================
  Hits         10570     10570           
Impacted Files Coverage Δ
components/space/index.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MadCcc MadCcc merged commit c76d9fe into ant-design:feature May 11, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants