Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add onPopupClick props #42272

Merged
merged 2 commits into from
May 11, 2023
Merged

Conversation

duriann
Copy link
Contributor

@duriann duriann commented May 11, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #42265

💡 Background and solution

新增onPopupClick事件,可用于阻止content内部的事件冒泡。

📝 Changelog

Language Changelog
🇺🇸 English add onPopupClick props
🇨🇳 Chinese 新增 onPopupClick 属性

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 3d18055

Added a new prop onPopupClick to Popconfirm component to enable custom click handling on the popconfirm content. Updated the API documentation, the demo, and the test cases accordingly. Also sorted and reordered some imports to follow the code style guidelines.

🔍 Walkthrough

🤖 Generated by Copilot at 3d18055

  • Add onPopupClick prop to Popconfirm component to allow customizing the click event on the popconfirm content (link, link, link, link)
  • Update API documentation for Popconfirm component in English and Chinese to include the new onPopupClick prop (link, link)
  • Add a test case for onPopupClick prop in components/popconfirm/__tests__/index.test.tsx to verify its functionality (link)
  • Reorder imports alphabetically in components/popconfirm/index.tsx, components/popconfirm/demo/basic.tsx, and components/popconfirm/PurePanel.tsx to follow the code style guidelines (link, link, link)

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c76d9fe) 100.00% compared to head (e2abb09) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #42272   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          619       619           
  Lines        10570     10570           
  Branches      2886      2886           
=========================================
  Hits         10570     10570           
Impacted Files Coverage Δ
components/popconfirm/PurePanel.tsx 100.00% <ø> (ø)
components/popconfirm/index.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit 1d9cab6 into ant-design:feature May 11, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants