Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Steps size small of CP #42278

Merged
merged 2 commits into from
May 11, 2023
Merged

Conversation

wanghui2021
Copy link
Contributor

@wanghui2021 wanghui2021 commented May 11, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix ConfigProvider size prop not work on Steps.
🇨🇳 Chinese 修复 ConfigProvider size 对 Steps 无效的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 7c2ed5e

Refactored Steps component to use useSize hook and added a test case for size inheritance from ConfigProvider. Renamed size prop to customizeSize for clarity.

🔍 Walkthrough

🤖 Generated by Copilot at 7c2ed5e

  • Rename size prop to customizeSize and use useSize hook to get the component size from global configuration or prop (link, link, link)
  • Add a test case to verify that Steps component inherits the size from ConfigProvider (link, link)

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e036396) 100.00% compared to head (b9cf7c4) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #42278   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          619       619           
  Lines        10547     10548    +1     
  Branches      2881      2881           
=========================================
+ Hits         10547     10548    +1     
Impacted Files Coverage Δ
components/steps/index.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit da67b48 into ant-design:master May 11, 2023
55 checks passed
@wanghui2021 wanghui2021 deleted the steps-small branch May 11, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants