chore: add warning of tip with spin #42293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
li-jia-nan
approved these changes
May 11, 2023
size-limit report 📦
|
|
cov 机器人又不 work 了 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #42293 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 619 619
Lines 10548 10550 +2
Branches 2881 2883 +2
=========================================
+ Hits 10548 10550 +2
☔ View full report in Codecov by Sentry. |
|
打脸了……刚说完就有了 |
|
为什么我升级到5.5.1还是有这个错误 |
5.6.3依然有 |
现在需要 将 tip 写在 children 里才能正常工作 否则会报错 v5.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #42291
💡 Background and solution
📝 Changelog
tipwhen not in nest pattern.tip的警告提示。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at c77da62
Improved the
tipprop validation and testing for theSpincomponent. Refactored the imports incomponents/spinfiles.🔍 Walkthrough
🤖 Generated by Copilot at c77da62
components/spin/__tests__/index.test.tsxandcomponents/spin/index.tsxto follow convention and group React imports (link, link)components/spin/index.tsxto log a warning whentipprop is used without a nested element (link)components/spin/index.tsxto rendertiponly whentipprop is present and component has a nested element (link)components/spin/__tests__/index.test.tsxto check warning and tip rendering logic (link)