Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: style not applied to overflowed Menu #42294

Merged
merged 2 commits into from
May 12, 2023
Merged

fix: style not applied to overflowed Menu #42294

merged 2 commits into from
May 12, 2023

Conversation

dhalenok
Copy link
Contributor

@dhalenok dhalenok commented May 11, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

None

💡 Background and solution

I've noticed that links in overflow menu were not working, if you were not clicking on the exact text in the link. This is due to prefixCls not being applied to the overflow menu.

Screenshot 2023-05-11 at 14 26 42 Screenshot 2023-05-11 at 14 27 13

📝 Changelog

Language Changelog
🇺🇸 English Fix style not applied to overflowed Menu
🇨🇳 Chinese 修復樣式不適用於溢出的菜單

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 5aa9d4f

Fixed a theme bug for the overflowed menu items in Menu component. Used classNames to handle the overflowedIndicatorPopupClassName prop of rc-menu.

🔍 Walkthrough

🤖 Generated by Copilot at 5aa9d4f

  • Fix popup menu theme bug for overflowed menu items by using classNames instead of string concatenation for overflowedIndicatorPopupClassName prop of rc-menu component (link in components/menu/menu.tsx)

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2023

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e036396) 100.00% compared to head (5aa9d4f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #42294   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          619       619           
  Lines        10547     10548    +1     
  Branches      2881      2881           
=========================================
+ Hits         10547     10548    +1     
Impacted Files Coverage Δ
components/menu/menu.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 2be6c47 into ant-design:master May 12, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants