fix: Popconfirm onVisibleChange trigger twice #42393
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #42314
ref #42351
💡 Background and solution
📝 Changelog
onVisibleChange
twice.onVisibleChange
会重复触发的问题。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at bda5438
Refactor and test the Popconfirm component. Improve the code style and readability of
components/popconfirm/__tests__/index.test.tsx
andcomponents/popconfirm/index.tsx
. Ensure backward compatibility with theonVisibleChange
prop.🔍 Walkthrough
🤖 Generated by Copilot at bda5438
Popconfirm
component (link)onVisibleChange
and trigger it along withonOpenChange
inhandleVisibleChange
function (link)onOpenChange
function toonInternalOpenChange
and remove props destructuring from it (link, link)onOpenChange
prop withonInternalOpenChange
function inPopover
component (link)onVisibleChange
is only triggered once when popconfirm is opened or closed (link)