Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ColorPicker): close panel when click clear button #42406

Merged
merged 4 commits into from
May 17, 2023

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented May 16, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

close panel when click clear button

📝 Changelog

Language Changelog
🇺🇸 English close panel when click clear button
🇨🇳 Chinese 点击清除按钮时隐藏面板

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 8a8b820

Refactored ColorPicker component and updated its test case. Added a clearColor feature that allows users to reset the color and hide the panel.

🔍 Walkthrough

🤖 Generated by Copilot at 8a8b820

  • Add clearColor feature to ColorPicker component to allow user to clear color selection (link, link)
  • Update test case for clearColor feature in index.test.tsx file (link)

@kiner-tang kiner-tang requested review from afc163 and zombieJ May 16, 2023 10:02
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 384.34 KB (+15 B 🔺)
./dist/antd-with-locales.min.js 443.58 KB (+14 B 🔺)

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2274111) 100.00% compared to head (e1f8720) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #42406   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          640       640           
  Lines        10839     10842    +3     
  Branches      2944      2945    +1     
=========================================
+ Hits         10839     10842    +3     
Impacted Files Coverage Δ
components/color-picker/ColorPicker.tsx 100.00% <100.00%> (ø)
...omponents/color-picker/components/ColorTrigger.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kiner-tang kiner-tang requested a review from afc163 May 16, 2023 11:45
@kiner-tang kiner-tang force-pushed the color-picker-clear-autoclose branch from e7c8fcb to e1f8720 Compare May 16, 2023 23:02
@afc163 afc163 merged commit 7183eab into master May 17, 2023
86 checks passed
@afc163 afc163 deleted the color-picker-clear-autoclose branch May 17, 2023 01:58
@MadCcc MadCcc mentioned this pull request May 22, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants