Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tag with Tooltip should not affect style #42414

Merged
merged 1 commit into from
May 16, 2023
Merged

fix: Tag with Tooltip should not affect style #42414

merged 1 commit into from
May 16, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 16, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #42387

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tag wrapped with Tooltip will use wrong font-size when hover.
🇨🇳 Chinese 修复 Tag 被 Tooltip 包裹时,Hover 会导致 font-size 错误的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 869cc64

Add resetStyle prop to Tooltip component to allow custom styling. Update components/tooltip/style/index.ts to support this prop.

🔍 Walkthrough

🤖 Generated by Copilot at 869cc64

  • Add a new prop resetStyle to the Tooltip component, which controls whether to apply the default style reset or not (link, )

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 384.32 KB (+8 B 🔺)
./dist/antd-with-locales.min.js 443.56 KB (+6 B 🔺)

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8222062) 99.99% compared to head (869cc64) 99.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #42414   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         640      640           
  Lines       10840    10840           
  Branches     2944     2944           
=======================================
  Hits        10839    10839           
  Misses          1        1           
Impacted Files Coverage Δ
components/tooltip/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit 4460ff4 into master May 16, 2023
95 checks passed
@zombieJ zombieJ deleted the fix-tag branch May 16, 2023 14:24
@zombieJ zombieJ mentioned this pull request May 18, 2023
20 tasks
@MadCcc MadCcc mentioned this pull request May 22, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag font size getting bigger when Tooltip is shown
2 participants