fix: Menu item icon not centered when itemMarginInline
is 0
#42426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
I was customizing theme with menu item's
itemMarginInline
to be 0, then I found that the icon is not centered when the menu is collapsed.reproduction link
It seems like the
paddingInline
calc logic caused this bug. Don't know why usingfontSizeSM
here, cause any other font here is LG. The correct calc logic should becalc(50% - ${fontSizeLG / 2}px - ${itemMarginInline}px)
📝 Changelog
itemMarginInline
is 0☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 6a2b643
Improve vertical menu style and layout. Adjust the
getVerticalStyle
function incomponents/menu/style/vertical.tsx
to fix spacing and alignment issues.🔍 Walkthrough
🤖 Generated by Copilot at 6a2b643