fix: Popconfirm margin problem when icon is null #42433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
size-limit report 📦
|
afc163
force-pushed
the
fix/popconfirm-margin
branch
from
69e3c73
to
dd7cce4
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #42433 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 640 640
Lines 10841 10843 +2
Branches 2945 2945
=========================================
+ Hits 10841 10843 +2
☔ View full report in Codecov by Sentry. |
li-jia-nan
approved these changes
May 17, 2023
kiner-tang
approved these changes
May 17, 2023
MadCcc
reviewed
May 17, 2023
| })} | ||
| > | ||
| {getRenderPropValue(title)} | ||
| <div className={`${prefixCls}-message-text`}> |
There was a problem hiding this comment.
确实没有，放个 div 也行。但是为了有点语义表达，还是放一个 className。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #42417 (comment)
💡 Background and solution
重构了 Popconfirm 的 dom 结构，如果手动覆盖样式可能会被影响。
核心改动在：https://github.com/ant-design/ant-design/pull/42433/files#diff-d57f0a697c7d1520b5a3174edf0317ae67cb31369b7ca569afa32ce074e2c770
📝 Changelog
titleanddescriptionwhenicon={null}.icon={null}时title和description的多余 margin 问题。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 69e3c73
This pull request enhances the popconfirm component by refactoring its message rendering, improving its style and alignment, and fixing a test file typo. It affects the files
components/popconfirm/PurePanel.tsx,components/popconfirm/style/index.tsx, andcomponents/popconfirm/__tests__/index.test.tsx.🔍 Walkthrough
🤖 Generated by Copilot at 69e3c73
PurePanel.tsx(link)${prefixCls}-message-textand render them only if truthy inPurePanel.tsx(link)style/index.tsx(link)${componentCls}-messageselector instyle/index.tsx(link)style/index.tsx(link)__tests__/index.test.tsx(link)