prefer: optimize allow clear logic #42439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
changelog 可以写详细一些 |
kiner-tang
reviewed
May 17, 2023
ok |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #42439 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 640 640
Lines 10819 10823 +4
Branches 2936 2937 +1
=========================================
+ Hits 10819 10823 +4
☔ View full report in Codecov by Sentry. |
|
覆盖率掉了 |
看到了，在修复 |
li-jia-nan
approved these changes
May 18, 2023
|
好像还是 0%： Kapture.2023-05-18.at.14.34.54.mp4 |
|
需要操作一下才行，随便拖动一下色板 |
|
感觉这样有点奇怪，不拖动色板可以实现吗？ |
没操作那肯定还是清空的状态，你只是打开面板而已，不应该去动清空的状态，这个符合常识，不然我每次打开清空就没了，感觉像个bug |
OK，那让 @MadCcc 闲夕大佬看一下吧，没问题就合了 |
这个不如直接在这个 PR 做掉吧 |
可以，我在 rc 加个属性好了 |
MadCcc
reviewed
May 19, 2023
| @@ -9,7 +10,7 @@ import ColorPresets from './components/ColorPresets'; | |||
| import type { ColorPickerBaseProps } from './interface'; | |||
|
|
|||
| interface ColorPickerPanelProps extends ColorPickerBaseProps { | |||
| onChange?: (value?: Color) => void; | |||
| onChange?: (value?: Color, type?: HsbaColorType) => void; | |||
MadCcc
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
allowClearinteraction logic, reopening the panel to select a color will default to 100% transparency instead of 0%.allowClear交互逻辑，重新打开面板选择颜色会默认 100% 透明度，而不是 0%。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at aefdeda
This pull request improves the
color-pickercomponent by adding more tests and fixing a bug with the alpha slider. The tests cover the basic interactions with the component, and the bug fix ensures that the alpha slider resets correctly after clearing the color.🔍 Walkthrough
🤖 Generated by Copilot at aefdeda
components/color-picker/ColorPicker.tsx