Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade @ant-design/icons to 5.1.0 #42443

Merged
merged 7 commits into from
May 18, 2023
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 17, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

ant-design/ant-design-icons#570
ant-design/ant-design-icons#571

ref #39900

💡 Background and solution

- AccountBookFilled.displayName = 'AccountBookFilled';
+ if (process.env.NODE_ENV !== 'production') {
+   AccountBookFilled.displayName = 'AccountBookFilled';
+ }

📝 Changelog

Language Changelog
🇺🇸 English - Reduce 1KB @ant-design/icons bundle size.
- Fix TwoTone icon color to primary color of 5.0.
🇨🇳 Chinese - 优化 @ant-design/icons 的 bundle 体积大小。
- 修复 TwoTone 类的图标色为 5.0 的新主色。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at ab5c62d

Updated @ant-design/icons dependency to a newer version to fix icon rendering and compatibility issues. This was part of a performance and stability improvement pull request.

🔍 Walkthrough

🤖 Generated by Copilot at ab5c62d

  • Update the version of @ant-design/icons to fix icon issues (link)

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 383.38 KB (+19 B 🔺)
./dist/antd-with-locales.min.js 442.71 KB (+16 B 🔺)

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bb6e0f5) 100.00% compared to head (3425686) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #42443   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          640       640           
  Lines        10843     10843           
  Branches      2945      2945           
=========================================
  Hits         10843     10843           
Impacted Files Coverage Δ
components/result/noFound.tsx 100.00% <ø> (ø)
components/upload/style/picture.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

package.json Outdated Show resolved Hide resolved
@afc163 afc163 changed the title perf: reduce icons size by remove displayName in production mode fix: upgrade @ant-design/icons to 5.1.0 May 17, 2023
@afc163 afc163 marked this pull request as ready for review May 17, 2023 12:37
@zombieJ zombieJ merged commit d90c1c6 into master May 18, 2023
88 checks passed
@zombieJ zombieJ deleted the perf/upgrade-antd-icons branch May 18, 2023 01:40
@MadCcc MadCcc mentioned this pull request May 22, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants