Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(table): Modify borderRadius in filter dropdown #42451

Merged
merged 2 commits into from
May 18, 2023

Conversation

Yuiai01
Copy link
Contributor

@Yuiai01 Yuiai01 commented May 17, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #42444

💡 Background and solution

由于外层存在 border-radius 因此使用最外层的 border-radius

📝 Changelog

Language Changelog
🇺🇸 English Modify border-radius in filter dropdown
🇨🇳 Chinese 修改筛选下拉菜单的 border-radius

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 282d416

Fix filter dropdown overflow bug and improve filter style in filter.ts. Refactor import order and border radius for better code quality and consistency.

🔍 Walkthrough

🤖 Generated by Copilot at 282d416

  • Fix filter dropdown overflow and border radius issues in table component (link, link)
  • Reorder import of resetComponent function to follow code style convention (link)

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d90c1c6) 100.00% compared to head (72d2fa3) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #42451   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          640       640           
  Lines        10941     10843   -98     
  Branches      2986      2945   -41     
=========================================
- Hits         10941     10843   -98     
Impacted Files Coverage Δ
components/table/style/filter.ts 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit dc2add0 into ant-design:master May 18, 2023
52 checks passed
@MadCcc MadCcc mentioned this pull request May 22, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rounded bottom border in table filter menu in dark mode
3 participants