Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove rc-util/lib/Dom/addEventListener #42464

Merged
merged 5 commits into from
May 18, 2023
Merged

refactor: remove rc-util/lib/Dom/addEventListener #42464

merged 5 commits into from
May 18, 2023

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented May 18, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English refactor: remove rc-util/lib/Dom/addEventListener
🇨🇳 Chinese 移除 addEventListener 方法,用原生代替

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at a8230ba

Improved the Chinese translation of the Affix component documentation in components/affix/index.zh-CN.md. Replaced the ambiguous word "固定" with the more specific "固钉".

🔍 Walkthrough

🤖 Generated by Copilot at a8230ba

  • Replace the term "固定" with "固钉" in the Chinese documentation of the Affix component to match the component name and the English documentation (link,link)

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2023

@li-jia-nan li-jia-nan changed the title docs: fix typo in docs docs: fix typo in docs 固定 => 固钉 May 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 383.34 KB (-104 B 🔽)
./dist/antd-with-locales.min.js 442.67 KB (-81 B 🔽)

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ecc384e) 100.00% compared to head (57b679d) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #42464    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          640       640            
  Lines        10951     10825   -126     
  Branches      2986      2941    -45     
==========================================
- Hits         10951     10825   -126     
Impacted Files Coverage Δ
components/affix/utils.ts 100.00% <ø> (ø)
components/affix/index.tsx 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jia-nan li-jia-nan closed this May 18, 2023
@li-jia-nan li-jia-nan deleted the Affix branch May 18, 2023 07:21
@li-jia-nan li-jia-nan restored the Affix branch May 18, 2023 08:41
@li-jia-nan li-jia-nan reopened this May 18, 2023
@li-jia-nan li-jia-nan changed the title docs: fix typo in docs 固定 => 固钉 refactor: remove rc-util/lib/Dom/addEventListener May 18, 2023
@li-jia-nan li-jia-nan requested a review from zombieJ May 18, 2023 08:44
@li-jia-nan
Copy link
Member Author

去年把其它地方的 addEventListener 都删掉了,遗留了这里

@li-jia-nan li-jia-nan requested a review from afc163 May 18, 2023 10:36
@afc163 afc163 merged commit 8f1d496 into master May 18, 2023
94 checks passed
@afc163 afc163 deleted the Affix branch May 18, 2023 12:35
components/affix/index.tsx Show resolved Hide resolved
components/affix/index.tsx Show resolved Hide resolved
components/affix/index.tsx Show resolved Hide resolved
@li-jia-nan
Copy link
Member Author

@li-jia-nan li-jia-nan mentioned this pull request May 18, 2023
20 tasks
@MadCcc MadCcc mentioned this pull request May 22, 2023
20 tasks
@afc163
Copy link
Member

afc163 commented Mar 31, 2024

图片

不知道哪里又冒出来了。

@afc163
Copy link
Member

afc163 commented Mar 31, 2024

@li-jia-nan
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants