Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select scrollbar rtl direction position #42508

Merged

Conversation

BoyYangzai
Copy link
Contributor

@BoyYangzai BoyYangzai commented May 20, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Select scrollbar rtl direction position
🇨🇳 Chinese 修复 Select direction 为 rtl 时 scrollbar 的位置

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 85361e1

This pull request improves the compatibility and functionality of the Select, Cascader, and TreeSelect components by adding right-to-left support and updating their dependencies.

🔍 Walkthrough

🤖 Generated by Copilot at 85361e1

  • Add direction prop to Select component to control the alignment and animation of the dropdown menu (link)
  • Use ConfigContext provider to get the global direction setting and pass it to the InternalSelect component as contextDirection prop (link)
  • Simplify the logic of passing the direction value to the rc-select component by using a local variable direction (link)
  • Update rc-cascader dependency to fix the direction support of the cascading menu and use it in the Cascader component (components/select/index.tsx, link)
  • Update rc-select dependency to enable customizing the dropdown menu style and className and use it in the Select component (components/select/index.tsx, link)
  • Update rc-tree-select dependency to enable customizing the tree node icon and use it in the TreeSelect component (components/select/index.tsx, link)

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2023

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
rc-select@14.5.0 None +0 zombiej
rc-tree-select@5.9.0 None +1 zombiej
rc-cascader@3.12.0 None +1 zombiej

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7461a21) 100.00% compared to head (85361e1) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #42508   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          640       640           
  Lines        10823     10824    +1     
  Branches      2937      2938    +1     
=========================================
+ Hits         10823     10824    +1     
Impacted Files Coverage Δ
components/select/index.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yoyo837 yoyo837 merged commit e4f84e0 into ant-design:master May 20, 2023
57 checks passed
@MadCcc MadCcc mentioned this pull request May 22, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong scroll position in Select drop down list in rtl (right to left)
2 participants