Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing translation in mn_MN.ts #42512

Merged
merged 4 commits into from
May 22, 2023
Merged

add missing translation in mn_MN.ts #42512

merged 4 commits into from
May 22, 2023

Conversation

ariunbatb
Copy link
Contributor

@ariunbatb ariunbatb commented May 22, 2023 •
edited

added OK text translation in MN

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English add missing translation in mn_MN.ts
🇨🇳 Chinese 在 mn_MN.ts 中添加缺失的翻译

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 2fea754

Improved Mongolian translations for some components. Updated the mn_MN locale file to use 'Тийм' instead of 'OK' for confirmation buttons.

🔍 Walkthrough

🤖 Generated by Copilot at 2fea754

  • Localize confirmation buttons for Mongolian language and culture (link, link)
  • Change filterConfirm property of Table component from 'OK' to 'Тийм' (link)
  • Change okText and justOkText properties of Modal and Popconfirm components from 'OK' to 'Тийм' (link)

@ariunbatb
Update mn_MN.ts
2fea754 
added OK text translation in MN

added OK text translation in MN

Revert "added OK text translation in MN"

This reverts commit 7958ac3.
@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023 •
edited

@yoyo837
Copy link
Contributor

yoyo837 commented May 22, 2023

Please fill changelog in the PR

@ariunbatb
Copy link
Contributor Author

add missing translation in mn_MN.ts

@yoyo837
Copy link
Contributor

yoyo837 commented May 22, 2023

In here:
image

@li-jia-nan
Copy link
Member

In here

我给他加上了

@li-jia-nan
Copy link
Member

update snap pls.

@ariunbatb
Copy link
Contributor Author

ariunbatb commented May 22, 2023 •
edited

update snap pls.

what does update snap means? Can you elaborate more

@li-jia-nan
Copy link
Member

li-jia-nan commented May 22, 2023 •
edited

update snap pls.

what does update snap means? Can you elaborate more

CI failed because the snapshot changed, you need execute npm run test:update components/locale to update snapshot

@li-jia-nan
Copy link
Member

image

@ariunbatb
Copy link
Contributor Author

image

done

update snap pls.

what does update snap means? Can you elaborate more

CI failed because the snapshot changed, you need execute npm run test:update components/locale to update snapshot

done

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2f9a8c7) 100.00% compared to head (4b815cb) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master    #42512   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          640       640           
  Lines        10824     10824           
  Branches      2938      2938           
=========================================
  Hits         10824     10824
Impacted Files Coverage Δ
components/locale/mn_MN.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ariunbatb
Copy link
Contributor Author

All checks have passed

@afc163 afc163 merged commit 91c1638 into ant-design:master May 22, 2023
52 checks passed
@ariunbatb
Copy link
Contributor Author

failed in commit. it says "Some checks were not successful". Sorry it's my first time

@li-jia-nan
Copy link
Member

failed in commit. it says "Some checks were not successful". Sorry it's my first time

You can ignore it, thanks for your contribution

This was referenced May 22, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-jia-nan li-jia-nan li-jia-nan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ariunbatb @yoyo837 @li-jia-nan @afc163