Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select check & remove icon align #42513

Merged
merged 1 commit into from
May 22, 2023
Merged

fix: select check & remove icon align #42513

merged 1 commit into from
May 22, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 22, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

resolve #42489

📝 Changelog

Language Changelog
🇺🇸 English Fix Select remove & selected icon not align in center.
🇨🇳 Chinese 修复 Select 移除和选中按钮不居中的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at f0cb6ec

The pull request enhances the style and code quality of the Select component, especially for the single-select and multiple-select dropdowns. It imports some utilities, removes unused code, and adds flexbox styles to components/select/style/dropdown.tsx and components/select/style/multiple.tsx.

🔍 Walkthrough

🤖 Generated by Copilot at f0cb6ec

  • Align selected values and icons in single-select and multiple-select dropdown components by adding flex styles to genSingleStyle and genSizeStyle functions (link, link)
  • Import resetComponent and textEllipsis utilities from ../../style in dropdown.tsx to apply common styles to the dropdown components (link)
  • Remove unused imports of the same utilities from multiple.tsx to clean up the code (link)

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 383.43 KB (+7 B 🔺)
./dist/antd-with-locales.min.js 442.75 KB (+7 B 🔺)

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e4f84e0) 100.00% compared to head (f0cb6ec) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #42513    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          640       640            
  Lines        11248     10824   -424     
  Branches      3067      2938   -129     
==========================================
- Hits         11248     10824   -424     
Impacted Files Coverage Δ
components/select/style/dropdown.tsx 100.00% <ø> (ø)
components/select/style/multiple.tsx 100.00% <ø> (ø)

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit 2f9a8c7 into master May 22, 2023
95 checks passed
@zombieJ zombieJ deleted the select-align branch May 22, 2023 03:13
This was referenced May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select multiple style have align issues
3 participants