New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ColorPicker HEX input cursor jump bug #44137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
MadCcc
reviewed
Aug 9, 2023
gouge666
force-pushed
the
fixcolorpicker
branch
from
August 9, 2023 15:47
d30579a
to
b85fedf
Compare
分支 rebase 同步一下上游 |
ping |
gouge666
force-pushed
the
fixcolorpicker
branch
from
August 11, 2023 13:35
4514758
to
7c9faff
Compare
同步了 |
Could you fix test case by updating jest snapshot? |
Test fail |
ping |
要不直接起个新PR另外修复吧. |
ping |
… letter,the cursor will jump to the tail,and me fixed it.
afc163
approved these changes
Aug 16, 2023
afc163
changed the title
fix(color-picker): when inputting in the HEX,if you input a lowercase…
fix: ColorPicker HEX input cursor jump bug
Aug 16, 2023
This was referenced Aug 29, 2023
This was referenced Sep 6, 2023
This was referenced Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… letter,the cursor will jump to the tail,and me fixed it.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at d30579a
Fixed a focus bug in the color picker hex input by using CSS instead of JavaScript to uppercase the input value. Modified the
value
andstyles
props of theInput
component incomponents/color-picker/components/ColorHexInput.tsx
.🔍 Walkthrough
🤖 Generated by Copilot at d30579a
textTransform: 'uppercase'
CSS rule instead of callingtoUpperCase
method onvalue
prop ofInput
component (link)