Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ColorPicker HEX input cursor jump bug #44137

Merged
merged 2 commits into from Aug 16, 2023

Conversation

gouge666
Copy link
Contributor

@gouge666 gouge666 commented Aug 9, 2023

… letter,the cursor will jump to the tail,and me fixed it.

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix ColorPicker HEX input cursor jump bug.
🇨🇳 Chinese 修复 ColorPicker 色值输入框输入小写英文字母时光标跳动的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at d30579a

Fixed a focus bug in the color picker hex input by using CSS instead of JavaScript to uppercase the input value. Modified the value and styles props of the Input component in components/color-picker/components/ColorHexInput.tsx.

🔍 Walkthrough

🤖 Generated by Copilot at d30579a

  • Fix bug where hex value input loses focus when typing lowercase letters by applying textTransform: 'uppercase' CSS rule instead of calling toUpperCase method on value prop of Input component (link)

@stackblitz
Copy link

stackblitz bot commented Aug 9, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

@argos-ci
Copy link

argos-ci bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Aug 16, 2023, 12:32 PM

@RedJue
Copy link
Member

RedJue commented Aug 10, 2023

分支 rebase 同步一下上游

@RedJue
Copy link
Member

RedJue commented Aug 11, 2023

ping

@gouge666
Copy link
Contributor Author

分支 rebase 同步一下上游

同步了

@afc163
Copy link
Member

afc163 commented Aug 11, 2023

Could you fix test case by updating jest snapshot?

@RedJue
Copy link
Member

RedJue commented Aug 11, 2023

Test fail

@RedJue
Copy link
Member

RedJue commented Aug 14, 2023

ping

@yoyo837
Copy link
Contributor

yoyo837 commented Aug 15, 2023

要不直接起个新PR另外修复吧.

@afc163
Copy link
Member

afc163 commented Aug 16, 2023

ping

@afc163 afc163 changed the title fix(color-picker): when inputting in the HEX,if you input a lowercase… fix: ColorPicker HEX input cursor jump bug Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants