Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pagination #44226

Merged
merged 1 commit into from Aug 15, 2023
Merged

chore: update pagination #44226

merged 1 commit into from Aug 15, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 15, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

resolve #10044

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Pagination itemRender still render node when customize with null.
🇨🇳 Chinese 修复 Pagination itemRender 自定义为 null 时,仍然渲染节点的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 5274b04

Updated rc-pagination dependency to fix a bug with the Pagination component's size changer. The bug affected scenarios where the total items were fewer than the page size.

🔍 Walkthrough

🤖 Generated by Copilot at 5274b04

  • Updated rc-pagination dependency to fix size changer bug (link)

@stackblitz
Copy link

stackblitz bot commented Aug 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2023

@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: rc-pagination@3.5.0

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 387.11 KB
./dist/antd-with-locales.min.js 446.18 KB

@argos-ci
Copy link

argos-ci bot commented Aug 15, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Aug 15, 2023, 3:29 AM

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (16f0738) 100.00% compared to head (5274b04) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44226   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          659       659           
  Lines        11199     11199           
  Branches      3033      3033           
=========================================
  Hits         11199     11199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit aff2bb7 into master Aug 15, 2023
95 checks passed
@zombieJ zombieJ deleted the bump-pagination branch August 15, 2023 06:14
afc163 pushed a commit to gouge666/ant-design that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to disable Pager on Pagination
3 participants