New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Descriptions
key prop issue
#44278
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
RedJue
force-pushed
the
fix-descriptions-key-prop-issue
branch
from
August 17, 2023 12:32
2e65729
to
9e3b697
Compare
MadCcc
approved these changes
Aug 17, 2023
kiner-tang
approved these changes
Aug 17, 2023
size-limit report 📦
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #44278 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 659 659
Lines 11199 11199
Branches 3033 3033
=========================================
Hits 11199 11199
☔ View full report in Codecov by Sentry. |
This was referenced Aug 17, 2023
This was referenced Aug 18, 2023
This was referenced Aug 25, 2023
This was referenced Aug 29, 2023
This was referenced Sep 6, 2023
This was referenced Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #44250
💡 Background and solution
📝 Changelog
Descriptions
where the throws react key error☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 2e65729
Fix a react key prop error in
Descriptions
component when using jsx mode. Clone child props instead of mutating them inuseRow
hook. Add a test case for the bug fix.🔍 Walkthrough
🤖 Generated by Copilot at 2e65729
components/descriptions/hooks/useRow.ts
to clone the props of each child node instead of mutating them (link)