Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge master into feature #46710

Merged
merged 6 commits into from
Dec 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 19 additions & 0 deletions CHANGELOG.en-US.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,25 @@ tag: vVERSION

---

## 5.12.6

`2023-12-30`

- 🐞 Fix Upload accessibility issue of tabbing twicely. [#46432](https://github.com/ant-design/ant-design/pull/46432)
- 🐞 Fix Modal `footer` Button duplicated gap style. [#46702](https://github.com/ant-design/ant-design/pull/46702)
- Select
- 🐞 Fix Select that scrollbar do not display in some case. [#46696](https://github.com/ant-design/ant-design/pull/46696) [@MadCcc](https://github.com/MadCcc)
- 💄 Optimize Select style of multiple selection. [#46646](https://github.com/ant-design/ant-design/pull/46646) [@MadCcc](https://github.com/MadCcc)
- Tree
- 🐞 Fix Tree that scrollbar do not display in some case. [#46672](https://github.com/ant-design/ant-design/pull/46672) [@yyz945947732](https://github.com/yyz945947732)
- 💄 Optimize Tree the TreeNode style when focused. [#46608](https://github.com/ant-design/ant-design/pull/46608) [@MadCcc](https://github.com/MadCcc)
- 🐞 Fix Layout.Sider will collapse when trigger printer. [#46650](https://github.com/ant-design/ant-design/pull/46650) [@anilpixel](https://github.com/anilpixel)
- 🐞 Fix Table style with edge shadow overflow. [#46644](https://github.com/ant-design/ant-design/pull/46644) [@Fatpandac](https://github.com/Fatpandac)
- 🐞 Typography.Text should update the Tooltip when the width changes. [#46613](https://github.com/ant-design/ant-design/pull/46613) [@linxianxi](https://github.com/linxianxi)
- 🐞 Fix Tooltip, Popover or other popup like component arrow issue when in nest case. [#46294](https://github.com/ant-design/ant-design/pull/46294) [@bestlyg](https://github.com/bestlyg)
- TypeScript
- 🤖 Export ConfigProvider `ConfigProviderProps` type. [#46605](https://github.com/ant-design/ant-design/pull/46605) [@li-jia-nan](https://github.com/li-jia-nan)

## 5.12.5

`2023-12-22`
Expand Down
19 changes: 19 additions & 0 deletions CHANGELOG.zh-CN.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,25 @@ tag: vVERSION

---

## 5.12.6

`2023-12-30`

- 🐞 修复 Upload 组件包裹 Button 时 Tab 键会聚焦两次的问题。[#46432](https://github.com/ant-design/ant-design/pull/46432)
- 🐞 修复 Modal `footer` 内 Button 可能重复的边距样式问题。[#46702](https://github.com/ant-design/ant-design/pull/46702)
- Select
- 🐞 修复 Select 组件滚动条在某些条件下不会显示的问题。[#46696](https://github.com/ant-design/ant-design/pull/46696) [@MadCcc](https://github.com/MadCcc)
- 💄 优化 Select 组件多选时选项样式。[#46646](https://github.com/ant-design/ant-design/pull/46646) [@MadCcc](https://github.com/MadCcc)
- Tree
- 🐞 修复 Tree 组件滚动条在某些条件下不会显示的问题。[#46672](https://github.com/ant-design/ant-design/pull/46672) [@yyz945947732](https://github.com/yyz945947732)
- 💄 优化 Tree 组件 TreeNode 节点聚焦样式。[#46608](https://github.com/ant-design/ant-design/pull/46608) [@MadCcc](https://github.com/MadCcc)
- 🐞 修复触发打印时,Layout.Sider 会收起的问题。[#46650](https://github.com/ant-design/ant-design/pull/46650) [@anilpixel](https://github.com/anilpixel)
- 🐞 修复 Table 边缘阴影会超出 Table 高度。[#46644](https://github.com/ant-design/ant-design/pull/46644) [@Fatpandac](https://github.com/Fatpandac)
- 🐞 修复 Typography.Text 省略模式下修改宽度 Tooltip 不会触发的问题。[#46613](https://github.com/ant-design/ant-design/pull/46613) [@linxianxi](https://github.com/linxianxi)
- 🐞 修复 Tooltip、Popover 等弹出组件嵌套使用时,箭头样式问题。[#46294](https://github.com/ant-design/ant-design/pull/46294) [@bestlyg](https://github.com/bestlyg)
- TypeScript
- 🤖 ConfigProvider 导出 `ConfigProviderProps` 类型。[#46605](https://github.com/ant-design/ant-design/pull/46605) [@li-jia-nan](https://github.com/li-jia-nan)

## 5.12.5

`2023-12-22`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42270,8 +42270,6 @@ exports[`ConfigProvider components Upload configProvider 1`] = `
>
<span
class="config-upload"
role="button"
tabindex="0"
>
<input
accept=""
Expand Down Expand Up @@ -42368,7 +42366,6 @@ exports[`ConfigProvider components Upload configProvider componentDisabled 1`] =
>
<span
class="config-upload config-upload-disabled"
role="button"
>
<input
accept=""
Expand Down Expand Up @@ -42435,8 +42432,6 @@ exports[`ConfigProvider components Upload configProvider componentSize large 1`]
>
<span
class="config-upload"
role="button"
tabindex="0"
>
<input
accept=""
Expand Down Expand Up @@ -42533,8 +42528,6 @@ exports[`ConfigProvider components Upload configProvider componentSize middle 1`
>
<span
class="config-upload"
role="button"
tabindex="0"
>
<input
accept=""
Expand Down Expand Up @@ -42631,8 +42624,6 @@ exports[`ConfigProvider components Upload configProvider componentSize small 1`]
>
<span
class="config-upload"
role="button"
tabindex="0"
>
<input
accept=""
Expand Down Expand Up @@ -42729,8 +42720,6 @@ exports[`ConfigProvider components Upload normal 1`] = `
>
<span
class="ant-upload"
role="button"
tabindex="0"
>
<input
accept=""
Expand Down Expand Up @@ -42827,8 +42816,6 @@ exports[`ConfigProvider components Upload prefixCls 1`] = `
>
<span
class="prefix-Upload"
role="button"
tabindex="0"
>
<input
accept=""
Expand Down
10 changes: 5 additions & 5 deletions components/form/__tests__/__snapshots__/demo-extend.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -5184,15 +5184,17 @@ Array [
>
<span
class="ant-upload ant-upload-disabled"
role="button"
>
<input
accept=""
disabled=""
style="display: none;"
type="file"
/>
<div>
<button
style="border: 0px; background: none;"
type="button"
>
<span
aria-label="plus"
class="anticon anticon-plus"
Expand Down Expand Up @@ -5220,7 +5222,7 @@ Array [
>
Upload
</div>
</div>
</button>
</span>
</div>
</div>
Expand Down Expand Up @@ -21115,8 +21117,6 @@ exports[`renders components/form/demo/validate-other.tsx extend context correctl
>
<span
class="ant-upload"
role="button"
tabindex="0"
>
<input
accept=""
Expand Down
10 changes: 5 additions & 5 deletions components/form/__tests__/__snapshots__/demo.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -2718,15 +2718,17 @@ Array [
>
<span
class="ant-upload ant-upload-disabled"
role="button"
>
<input
accept=""
disabled=""
style="display:none"
type="file"
/>
<div>
<button
style="border:0;background:none"
type="button"
>
<span
aria-label="plus"
class="anticon anticon-plus"
Expand Down Expand Up @@ -2754,7 +2756,7 @@ Array [
>
Upload
</div>
</div>
</button>
</span>
</div>
</div>
Expand Down Expand Up @@ -9675,8 +9677,6 @@ exports[`renders components/form/demo/validate-other.tsx correctly 1`] = `
>
<span
class="ant-upload"
role="button"
tabindex="0"
>
<input
accept=""
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -933,7 +933,6 @@ exports[`Form form should support disabled 1`] = `
>
<span
class="ant-upload ant-upload-disabled"
role="button"
>
<input
accept=""
Expand Down
4 changes: 2 additions & 2 deletions components/form/demo/disabled.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,10 @@ const FormDisabledDemo: React.FC = () => {
</Form.Item>
<Form.Item label="Upload" valuePropName="fileList" getValueFromEvent={normFile}>
<Upload action="/upload.do" listType="picture-card">
<div>
<button style={{ border: 0, background: 'none' }} type="button">
<PlusOutlined />
<div style={{ marginTop: 8 }}>Upload</div>
</div>
</button>
</Upload>
</Form.Item>
<Form.Item label="Button">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,6 @@ exports[`renders components/space/demo/base.tsx extend context correctly 1`] = `
>
<span
class="ant-upload"
role="button"
tabindex="0"
>
<input
accept=""
Expand Down
2 changes: 0 additions & 2 deletions components/space/__tests__/__snapshots__/demo.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,6 @@ exports[`renders components/space/demo/base.tsx correctly 1`] = `
>
<span
class="ant-upload"
role="button"
tabindex="0"
>
<input
accept=""
Expand Down
10 changes: 8 additions & 2 deletions components/upload/Dragger.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,14 @@ import type { UploadProps } from './interface';
export type DraggerProps = UploadProps & { height?: number };

const Dragger = React.forwardRef<UploadRef, DraggerProps>(
({ style, height, ...restProps }, ref) => (
<Upload ref={ref} {...restProps} type="drag" style={{ ...style, height }} />
({ style, height, hasControlInside = false, ...restProps }, ref) => (
<Upload
ref={ref}
hasControlInside={hasControlInside}
{...restProps}
type="drag"
style={{ ...style, height }}
/>
),
);

Expand Down
2 changes: 2 additions & 0 deletions components/upload/Upload.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ const InternalUpload: React.ForwardRefRenderFunction<UploadRef, UploadProps> = (
maxCount,
data = {},
multiple = false,
hasControlInside = true,
action = '',
accept = '',
supportServerRender = true,
Expand Down Expand Up @@ -350,6 +351,7 @@ const InternalUpload: React.ForwardRefRenderFunction<UploadRef, UploadProps> = (
disabled: mergedDisabled,
beforeUpload: mergedBeforeUpload,
onChange: undefined,
hasControlInside,
} as RcUploadProps;

delete rcUploadProps.className;
Expand Down