Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CP support Drawer closeIcon #46894

Merged
merged 13 commits into from Jan 26, 2024
Merged

feat: CP support Drawer closeIcon #46894

merged 13 commits into from Jan 26, 2024

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Jan 10, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English feat: CP support icons
🇨🇳 Chinese feat: CP 组件支持 icons

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 10, 2024

Visual Regression Report for PR #46894 Passed ✅

Target branch: feature (7664f39)


Congrats! No visual-regression diff found

Copy link
Contributor

github-actions bot commented Jan 10, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 10, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 331.28 KB (+14 B 🔺)
./dist/antd-with-locales.min.js 377.16 KB (-24 B 🔽)

Copy link

codesandbox-ci bot commented Jan 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d9a7e7b:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7664f39) 100.00% compared to head (d9a7e7b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #46894   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12559     12560    +1     
  Branches      3295      3296    +1     
=========================================
+ Hits         12559     12560    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan changed the title feat: CP support Drawer closeIcon (DON'T MERGE) type: CP support icons Jan 12, 2024
@li-jia-nan li-jia-nan changed the title type: CP support icons type: [WIP] CP support icons Jan 13, 2024
@li-jia-nan li-jia-nan changed the title type: [WIP] CP support icons type: CP support icons Jan 18, 2024
@li-jia-nan li-jia-nan changed the title type: CP support icons feature: CP support Drawer closeicon Jan 25, 2024
Signed-off-by: lijianan <574980606@qq.com>
Signed-off-by: lijianan <574980606@qq.com>
@MadCcc MadCcc merged commit bb6b475 into feature Jan 26, 2024
105 checks passed
@MadCcc MadCcc deleted the drawer-closeIcon branch January 26, 2024 02:52
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@li-jia-nan li-jia-nan changed the title feature: CP support Drawer closeicon feat: CP support Drawer closeIcon Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants