New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Modal static func #47010
fix: Modal static func #47010
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Visual Regression Report for PR #47010 Failed ❌
Check Full Report for details |
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0df762b:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #47010 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 732 732
Lines 12548 12552 +4
Branches 3291 3293 +2
=========================================
+ Hits 12548 12552 +4 ☔ View full report in Codecov by Sentry. |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #47007
💡 Background and solution
Modal.confirm
的prefixCls
不应该作为rootPrefixCls
生效,导致 CSSINJS Cache 命中策略失效 以及 子元素prefixCls
break change。📝 Changelog
prefixCls
breaks children other componentprefixCls
and thus bring the motion miss.prefixCls
时,会改变所有子元素的prefixCls
并导致动画丢失的问题。☑️ Self-Check before Merge