Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modal static func #47010

Merged
merged 3 commits into from Jan 17, 2024
Merged

fix: Modal static func #47010

merged 3 commits into from Jan 17, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 17, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #47007

💡 Background and solution

Modal.confirmprefixCls不应该作为 rootPrefixCls 生效,导致 CSSINJS Cache 命中策略失效 以及 子元素 prefixCls break change。

📝 Changelog

Language Changelog
🇺🇸 English Fix Modal static function with prefixCls breaks children other component prefixCls and thus bring the motion miss.
🇨🇳 Chinese 修复 Modal 静态方法配置 prefixCls 时,会改变所有子元素的 prefixCls 并导致动画丢失的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 17, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 17, 2024

Visual Regression Report for PR #47010 Failed ❌

Target branch: master (85fb745)
View Full Report


image name expected actual diff
qr-code-Popover.dark.png master: 85fb745bd141204230dbeb6ae6bfd702319c0eed current: pr-47010 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Jan 17, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 331.11 KB (-79 B 🔽)
./dist/antd-with-locales.min.js 377.06 KB (+25 B 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0df762b:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cdac522) 100.00% compared to head (0df762b) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47010   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12548     12552    +4     
  Branches      3291      3293    +2     
=========================================
+ Hits         12548     12552    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit be058e4 into master Jan 17, 2024
105 of 106 checks passed
@zombieJ zombieJ deleted the fix-static branch January 17, 2024 09:40
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@vagusX vagusX mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal.confirm motion missing
4 participants