Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spin): remove false positive warning with tip and fullscreen used together #47015

Merged
merged 2 commits into from Jan 19, 2024

Conversation

xsjcTony
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

closes #47014

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix false positive console warning for <Spin /> with tip and fullscreen used together
🇨🇳 Chinese 修复 <Spin /> 组件在 tipfullscreen 同时使用时的控制台误报

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 17, 2024

Visual Regression Report for PR #47015 Failed ❌

Target branch: master (a7cff93)
View Full Report


image name expected actual diff
qr-code-Popover.dark.png master: a7cff93db73436c89aee4179bebd3f0c28bc07e7 current: pr-47015 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Jan 17, 2024

Preview Is ready

Copy link

codesandbox-ci bot commented Jan 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d305547:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85fb745) 100.00% compared to head (d305547) 100.00%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47015   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12548     12553    +5     
  Branches      3291      3294    +3     
=========================================
+ Hits         12548     12553    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

components/spin/index.tsx Outdated Show resolved Hide resolved
@afc163 afc163 merged commit 87b45e6 into ant-design:master Jan 19, 2024
61 of 62 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

MadCcc pushed a commit that referenced this pull request Jan 29, 2024
…used together (#47015)

* fix(spin): remove false positive warning with `tip` and `fullscreen` used together

* fix(spin): update warning text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Spin /> false positively print warning in console for tip usage with fullscreen
3 participants