Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing ja table filter locale keys #47072

Merged

Conversation

sebastibe
Copy link
Contributor

@sebastibe sebastibe commented Jan 20, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

📝 Changelog

Language Changelog
🇺🇸 English Add missing locale keys in ja_JP locale for table filters
🇨🇳 Chinese 在表过滤器的 ja_JP 语言环境中添加缺少的语言环境键

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 20, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 20, 2024

Visual Regression Report for PR #47072 Failed ❌

Target branch: master (87b45e6)
View Full Report


image name expected actual diff
qr-code-Popover.dark.css-var.png master: 87b45e6198f4279a281a2cfb60af191dea7e11e2 current: pr-47072 diff

Check Full Report for details

Copy link

codesandbox-ci bot commented Jan 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 50358b1:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87b45e6) 100.00% compared to head (50358b1) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #47072   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12553     12553           
  Branches      3294      3294           
=========================================
  Hits         12553     12553           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

components/locale/ja_JP.ts Outdated Show resolved Hide resolved
@li-jia-nan li-jia-nan merged commit fe5295f into ant-design:master Jan 20, 2024
61 of 62 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

MadCcc pushed a commit that referenced this pull request Jan 29, 2024
* fix: add missing ja table filter locale keys

* fix: translate filterSearchPlaceholder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants